The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props bluefuton, westonruter, tfrommen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Should the same fix be applied to WP_HTTP_IXR_Client?

Should the same fix be applied to WP_HTTP_IXR_Client?

Yes, I think so. There's actually an open ticket already for this:

https://core.trac.wordpress.org/ticket/40784

And the suggested patch was:

https://core.trac.wordpress.org/attachment/ticket/40784/40784.diff

Shall I address it in this PR @westonruter?

@bluefuton ah, perfect. Yes, could you apply that patch to the PR and update it so we can address both together?

Yes, could you apply that patch to the PR and update it so we can address both together?

Added! 👍 I've modernized the original patch (using ?? to be consistent with the surrounding code and assertSame in tests for strict equality).

Sidenote

It looks like at one point IXR_Client was a third-party library by Simon Willison: https://simonwillison.net/2002/Sep/2/aNewXMLRPCLibraryForPHP/. This was back in 2002 and it is not actively maintained any more: https://simonwillison.net/2022/Jun/12/twenty-years/

If we are now treating it as part of WP, we could probably do some further cleanup in there, like dropping PHP4 support.

We should give @tfrommen props for the original patch on #40784 too :)

@bluefuton It seems the only difference between the constructors for the two classes is that WP_HTTP_IXR_Client also sets a scheme. That said, could WP_HTTP_IXR_Client::__construct() be further simplified to just:

	public function __construct( $server, $path = false, $port = false, $timeout = 15 ) {
		parent::__construct( $server, $path, $port, $timeout );
		$this->scheme = parse_url( $server, PHP_URL_SCHEME ) ?? 'http';
	}

It seems the only difference between the constructors for the two classes is that WP_HTTP_IXR_Client also sets a scheme. That said, could WP_HTTP_IXR_Client::__construct() be further simplified

Nice cleanup! There's one subtlety though - the parent IXR_Client::__construct() defaults the port to 80 when parsing a URL, while WP_HTTP_IXR_Client defaults to $port (which is false by default). We'd need to handle that too.

Hey, nice to see some work on this. 😉

The above suggestion by @westonruter would always default to 'http':

	public function __construct( $server, $path = false, $port = false, $timeout = 15 ) {
		parent::__construct( $server, $path, $port, $timeout );
		$this->scheme = parse_url( $server, PHP_URL_SCHEME ) ?? 'http';
	}

However, the current code only does this (hard-coded) if there was no $path specified.

To keep that behavior, we would need to put the code inside a conditional. Also covering the different handling of the port, this would give us this:

	public function __construct( $server, $path = false, $port = false, $timeout = 15 ) {
		parent::__construct( $server, $path, $port, $timeout );
		if ( ! $path ) {
			$this->scheme = parse_url( $server, PHP_URL_SCHEME ) ?? 'http';
			$this->port   = parse_url( $server, PHP_URL_PORT ) ?? '';
		}
	}

Thoughts?

I know we're a few years on from your original patch @tfrommen! Hope we can get it merged for you 🙂

The refactor to call parent::__construct() would definitely slim things down. It looks like there are a few subtle differences to navigate though, and personally I would choose to land the ?? additions and tests, and consider refactoring in a followup PR.

@bluefuton Sounds good to me.

@tfrommen How do you feel with the PR as it stands? If you approve, I'll proceed with commit.